Cancel button should work differently

spring-guides / gs-crud-with-vaadin

Creating CRUD UI with Vaadin :: Use Vaadin and Spring Data JPA to build a dynamic UI

https://spring.io/guides/gs/crud-with-vaadin

Apache License 2.0

108 stars 141 forks source link

Cancel button should work differently #108

Closed gwutz closed 1 year ago

gwutz commented 1 year ago

https://github.com/spring-guides/gs-crud-with-vaadin/blob/fbca9797d4901efde7f5c08695abbaaa0325ace7/complete/src/main/java/com/example/crudwithvaadin/CustomerEditor.java#L68

Hi! I made the tutorial and I really like it. I just realized that this line might be wrong here because when I cancel the "edit" operation the Editor should hide again. Therefore it makes sense to push null into the editCustomer function right?

Buzzardo commented 1 year ago

To repeat what I wrote on the related PR: People may wonder what happened to the window, so I'm going to leave it as it is. This would make a good short blog post to share with the community, though.