spring-guides / gs-crud-with-vaadin

Creating CRUD UI with Vaadin :: Use Vaadin and Spring Data JPA to build a dynamic UI
https://spring.io/guides/gs/crud-with-vaadin
Apache License 2.0
108 stars 141 forks source link

Requires node and npm to be installed #96

Closed wlfbck closed 1 year ago

wlfbck commented 2 years ago

Title, basically. Just downloaded the complete example and tried to run it. You will get an error from Vaadin (which is a bug in Vaadin; it should be installing it itself, but doesn't). This can be solved by manually installing node and npm, but should be mentioned in the guide.

mstahv commented 2 years ago

@wlfbck Did you file a bug to Vaadin repository? Because auto-installation of node should work. The version used but the tutorial was bit outdated, but it shouldn't matter in this case.

wlfbck commented 2 years ago

Yeah i reported it to them: https://github.com/vaadin/flow/issues/11056#issuecomment-967177115

That issue has been there for a while. I'm surprised not more people have run into it.

snicoll commented 1 year ago

@wlfbck let's follow up on the vaadin issue before changing the guide. If it turns out to be the case, I am trusting @mstahv to follow up with us.

mstahv commented 1 year ago

👍 The best thing about the latest version is that Node/npm isn't needed at all anymore, not even as autoinstalled 😎