spring-guides / gs-messaging-stomp-websocket

Using WebSocket to build an interactive web application :: Learn how to the send and receive messages between a browser and the server over a WebSocket
http://spring.io/guides/gs/messaging-stomp-websocket/
Apache License 2.0
530 stars 474 forks source link

Fix jquery link #58

Closed oncethor closed 4 years ago

oncethor commented 4 years ago

Hello, fixing the jquery link in the index.html file. WIthout this the demo doesn't work. I give all the needed permissions to use this code.

Thanks

pivotal-issuemaster commented 4 years ago

@oncethor Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 4 years ago

@oncethor Thank you for signing the Contributor License Agreement!

dsyer commented 4 years ago

I’m pretty sure this isn’t necessary. Look at the other webjars links - they don’t have the version in either.

oncethor commented 4 years ago

Thanks for taking the bother to respond!

I cloned the repo and tried to build and run it. This all goes well and looks good, but as soon as you look into the browser console you see the problem.

Maybe there is a better way to address this in the pom.xml itself, but I had to chase the place where - in the jars - the jquery was available and this is the result:

antonio@antonioRyzen
~/src/java/spring-boot/gs-messaging-stomp-websocket/complete/target/tmp/BOOT-INF/lib
(master) $ jar tvf jquery-3.1.0.jar
     0 Mon Aug 01 08:05:32 BST 2016 META-INF/
   131 Mon Aug 01 08:05:30 BST 2016 META-INF/MANIFEST.MF
     0 Mon Aug 01 08:05:28 BST 2016 META-INF/resources/
     0 Mon Aug 01 08:05:28 BST 2016 META-INF/resources/webjars/
     0 Mon Aug 01 08:05:28 BST 2016 META-INF/resources/webjars/jquery/
     0 Mon Aug 01 08:05:28 BST 2016
META-INF/resources/webjars/jquery/${version.unsnapshot}/
     0 Mon Aug 01 08:05:28 BST 2016 META-INF/resources/webjars/jquery/3.1.0/
   204 Mon Aug 01 08:05:28 BST 2016
META-INF/resources/webjars/jquery/${version.unsnapshot}/webjars-requirejs.js
263767 Mon Aug 01 08:05:28 BST 2016
META-INF/resources/webjars/jquery/3.1.0/jquery.js

* 86386 Mon Aug 01 08:05:32 BST 2016
META-INF/resources/webjars/jquery/3.1.0/jquery.min.js*131041 Mon Aug 01
08:05:30 BST 2016 META-INF/resources/webjars/jquery/3.1.0/jquery.min.map
     0 Mon Aug 01 08:05:32 BST 2016 META-INF/maven/
     0 Mon Aug 01 08:05:32 BST 2016 META-INF/maven/org.webjars/
     0 Mon Aug 01 08:05:32 BST 2016 META-INF/maven/org.webjars/jquery/
  7416 Mon Aug 01 08:05:20 BST 2016
META-INF/maven/org.webjars/jquery/pom.xml
   102 Mon Aug 01 08:05:32 BST 2016
META-INF/maven/org.webjars/jquery/pom.properties

Let me know if there is a better way to fix it.

dsyer commented 4 years ago

It's a bug in the jquery jar. If you change the version in the pom.xml to 3.1.1-1 (or 3.4.1 the latest), I think that will work.

oncethor commented 4 years ago

Thanks Dave for your fix :) I have opened a new PR.