search

spring-guides / gs-messaging-stomp-websocket

Using WebSocket to build an interactive web application :: Learn how to the send and receive messages between a browser and the server over a WebSocket
http://spring.io/guides/gs/messaging-stomp-websocket/
Apache License 2.0
530 stars 474 forks source link

Upgrading Stomp client dependencies #77

Closed marciopd closed 1 year ago

marciopd commented 1 year ago

Spring's websockets tutorial currently uses the stomp-websocket client library, which is not maintained anymore (last release 5 years ago).

This pull request updates the tutorial to use stomp-js, which is currently maintained and has plus 100K weekly downloads in npm.

StompJs's docs recommends explicitly not to use SockJs, unless you really need to support an old browser. That's why the SockJs setup was removed from the tutorial.

Something else that was changed is to get the Javascript dependencies directly in the html from CDNs.

Please let me know if the PR is welcome and if you would like any change before moving forwards.

Thanks in advance!

With kind regards, Márcio

marciopd commented 1 year ago

@bclozel, can you maybe review this one?

marciopd commented 1 year ago

Hi @sdeleuze and @Buzzardo , seems you were the last ones committing in this repo.

Any chance you could check this PR or point me who could?

Thanks in advance!

sdeleuze commented 1 year ago

Thanks for this useful PR, I am going to work on integrating it and update the related Spring Framework documentation.

sdeleuze commented 1 year ago

Merged, I am going to update Spring Framework documentation as well.

marciopd commented 1 year ago

Thanks @sdeleuze !