search

spring-guides / gs-scheduling-tasks

Scheduling Tasks :: Learn how to schedule tasks with Spring.
https://spring.io/guides/gs/scheduling-tasks/
Apache License 2.0
132 stars 164 forks source link

does not use awaitility #29

Closed glelouet closed 6 months ago

glelouet commented 9 months ago

The guide requests to add the awaitility dependency, though there is not test present, that dependency has test scope.

Proposal : oneOf

  1. add test that require that library
  2. remove that dependancy.
ttaolu commented 8 months ago

How to test use awaitility ?

naragon commented 7 months ago

If you look in the src/test under the completed project, you'll see the tests that use the Awaitility library. The guide itself should be updated though to include that in the instructions.

robertmcnees commented 6 months ago

Hi @glelouet. Thanks for the issue. Since 3.2, awaitility is now a dependency that Boot manages. I cleaned up the guide with PR #34 that should make things more clear.