search

spring-guides / gs-spring-boot

Building an Application with Spring Boot :: Learn how to build an application with minimal configuration.
https://spring.io/guides/gs/spring-boot/
Apache License 2.0
890 stars 4.51k forks source link

Why downgrade maven-compiler-plugin? #16

Closed mbyrne00 closed 10 years ago

mbyrne00 commented 10 years ago

Hi,

Firstly thanks for your work.

I'm sure there's a valid reason but can you please advise why the plugin is downgraded to 2.3.2 as per this commit: https://github.com/spring-guides/gs-spring-boot/commit/07ef9084138b4a755ea9e74dc862c346ee5c1e99 ?

If it's still valid it might be worth adding a comment above that plugin definition to let others know why they should leave it as it is.

Cheers

gregturn commented 10 years ago

The drone.io CI jobs were actually defaulting to a much older version of maven-compiler-plugin which predate Java 5 (no annotations). So I put in a fixed version so our jobs would work properly. I suppose a note would make sense since I don't recommend this in general practice.

mbyrne00 commented 10 years ago

Ah great thanks ... I won't downgrade then ;-)

gregturn commented 10 years ago

Resolved via https://github.com/spring-guides/getting-started-macros/commit/3b1f1db42050833dc042c48e6c14f86f2a6addaa and https://github.com/spring-guides/getting-started-macros/commit/8b34dcaef112cbe1343a74c55b3a978cd1b6ded5