spring-guides / gs-spring-boot

Building an Application with Spring Boot :: Learn how to build an application with minimal configuration.
https://spring.io/guides/gs/spring-boot/
Apache License 2.0
890 stars 4.51k forks source link

Applying changes from the Spring Academy port #164

Closed cschuyle closed 1 year ago

cschuyle commented 1 year ago

These are the changes we've made in the Spring Academy incarnation of this Guide ... but only the changes that are not specific to "in-Cloud" (Spring Academy) mode (i.e. instructions that differ for using the Educates workshop and its in-browser UI to follow the instructions, instead of the learner's local machine).

This PR is a placeholder for a conversation (or more than one).

Summary of changes:

pivotal-cla commented 1 year ago

@cschuyle Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Buzzardo commented 1 year ago

I've added some review comments to the code.

In addition to those:

Removed the codebase (initial and complete directories) entirely and adjust the instructions to start from an Initializr-generated codebase.

I'm not sure if we should do this or not, but if we do I think we need to review all guides to make sure that we are consistent.

Removed the maven option - all instructions only reference gradle.

I'm not sure that we should do this. Although Gradle is the default choice on start.spring.io many folks still use Maven.

I very much agree. First, we have 60 or so guides. That's a lot of change to match to only one changed guide.

Also, the Spring team itself uses both Gradle and Maven, and there are lot of strong feelings for and against both of them. As a case in point, Spring Batch moved from Gradle to Maven in the latest major version (version 5). Since the advent of Gradle, we have never been able to form a consensus about which to use.

On top of the internal issue, the Spring community uses both Maven and Gradle (sometimes in the same shop, just as we do), and I'd hate to lose either one.

cschuyle commented 1 year ago

Thanks for all your comments, folks! I've incorporated some into the current spring-guides repo.

cschuyle commented 1 year ago

Closing this PR because we've de-prioritized this effort, and recognizing that there are still at least two main points of conversation to pick up when the effort is re-kindled: