spring-guides / gs-spring-boot

Building an Application with Spring Boot :: Learn how to build an application with minimal configuration.
https://spring.io/guides/gs/spring-boot/
Apache License 2.0
890 stars 4.51k forks source link

Fix pre-opening HelloController.java #76

Closed KatanMichael closed 4 years ago

pivotal-issuemaster commented 4 years ago

@KatanMichael Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

dsyer commented 4 years ago

I'm quite interested in gitpod, but not sure we want to do it quite like this. And the "pre-open" thing isn't making sense yet. If there are 2 changes here I recommend breaking them out and rebasing both onto master.

dsyer commented 4 years ago

This looks like someone maybe just using the guide to practise or learn about github. Closing. Please open a new one if there is something you needed to fix.