search

spring-guides / gs-uploading-files

Uploading Files :: Learn how to build a Spring application that accepts multi-part file uploads.
http://spring.io/guides/gs/uploading-files/
Apache License 2.0
469 stars 503 forks source link

application.properties code style #17

Closed evershauke closed 8 years ago

evershauke commented 8 years ago

Hi,

I just read the guide for uploading files (https://spring.io/guides/gs/uploading-files/) and in the passage with the application.properties settings:

multipart.maxFileSize: 128KB multipart.maxRequestSize: 128KB

which is the slightly "inconsistent" code style for key/value pairs in properties-files. It would be more consistent if one would rename it to:

multipart.maxFileSize= 128KB multipart.maxRequestSize= 128KB

dsyer commented 8 years ago

What's inconsistent about it? Those are the only 2 properties.

evershauke commented 8 years ago

Because they use a different code style in their other documents/references and IDEA will give out a warning. (see: http://docs.spring.io/spring-boot/docs/current/reference/html/common-application-properties.html)

dsyer commented 8 years ago

I consider that a bug in IDEA then. I'm not sure it needs to lead to a change here (this guide is internally consistent and correct).

evershauke commented 8 years ago

I agree that it's a minor issue. You may close this then.