spring-io / antora-ui-spring

Mozilla Public License 2.0
13 stars 26 forks source link

feat: Update sidebar #251

Closed oodamien closed 2 weeks ago

oodamien commented 1 month ago
philwebb commented 1 month ago

I don't see a difference for the page/not page items in the tree. Here's a commit that updates the preview https://github.com/philwebb/antora-ui-spring/commit/2b1ff69dbecb839c8a8203b77c451804316b2aa7

philwebb commented 1 month ago

I wonder if we should also keep the chevron color the same as the text. It's the same when no selected, but when selected the text and chevron are different colors.

Screenshot 2024-05-28 at 11 38 55 AM

Screenshot 2024-05-28 at 11 39 01 AM

philwebb commented 3 weeks ago

When comparing to the stock Antora UI I think there are a couple of tweaks we should consider:

Screenshot 2024-06-13 at 5 58 20 PM

Screenshot 2024-06-13 at 5 59 42 PM

I think the stock version looks a little better because all items are left aligned (ours indents differently when the chevrons are present/missing). I also think the smaller chevrons look slightly better (but that's just cosmetic). docs.github.com use 16x16 icons which look pretty good.

philwebb commented 2 weeks ago

I'm a massive idiot and was looking at an old version of the code 🤕

If I use the actual current code things look good!

Screenshot 2024-06-14 at 4 34 18 AM