Asciinema casts are not rendered in latest ui bundle versions

spring-io / antora-ui-spring

Mozilla Public License 2.0

14 stars 26 forks source link

Asciinema casts are not rendered in latest ui bundle versions #264

Open Klopfy opened 1 month ago

Klopfy commented 1 month ago

I have noticed that some spring documentation does not display asciinema cast properly anymore.

Not working example with spring-shell doc

documentation link / source code
Spring shell uses the latest antora-ui-spring bundle

Screenshot

Working example with spring-cli doc

documentation link / source code
Spring cli uses the v0.4.7 of antora-ui-spring bundle
Screenshot

When trying to use asciinema extension on my end:

using antora-ui-spring bundle, it seems to be working up until v0.4.10 and then breaks after v.0.4.11.
using my own bundle, I have the same non-rendered cast issue. Not sure if the issue is on the bundle side or on the extension itself.

jvalkeal commented 1 month ago

I'm not yet sure on which side to fix it(ui or extension). Player is there but its width ends up having zero width. Essentially styling gets broken.

Klopfy commented 1 month ago

If it helps on the decision, I do have the very same on my own antora UI bundle (width: 0px;). I forked antora-ui-default one year ago and made some minor css change. Not sure if I introduced the same conflicting element as spring ui bundle.

jvalkeal commented 1 month ago

So what happened is a videoblock in:

<div class="videoblock">
<div class="content"><div id="7eaf8fd0409a6c92c72f93d72ca50bcb" style=" "></div></div>
</div>

I added that so that the container could be styled by a user. 0.4.11 added styling for that block and that somehow broke asciinema's automatic size calculation. We now get something like:

.doc .imageblock, .doc .videoblock {
    align-items: center;
    display: flex;
    flex-direction: column;
}

It looks to be flex confusing asciinema.