spring-io / antora-ui-spring

Mozilla Public License 2.0
15 stars 29 forks source link

Edit button does not show the file but ask you to fork if you don't have a fork #30

Closed jonatan-ivanov closed 1 year ago

jonatan-ivanov commented 3 years ago

If I click on the edit button, the link takes me to the edit view of the file on GH (not surprisingly): https://github.com/rwinch/spring-security/edit/antora/main/docs/modules/ROOT/pages/index.adoc

In case I don’t have a fork, this view won’t show me the file but this message: 'You need to fork this repository to propose changes.' If I have a fork, it edits the file.

I’m wondering if it worth to add an additional view button or a view button instead of edit so that users can see the file and click on edit icon if they want to propose a change: https://github.com/rwinch/spring-security/blob/antora/main/docs/modules/ROOT/pages/index.adoc

This can be useful if users wants to do any of these without forking the repo:

In order to do these, they need to either modify the url or go back to the folder of the file and open the file again.

rwinch commented 1 year ago

Thanks for the report.

I do not want to add additional complexity to our code (this would be a customization to Antora) and to the UI elements displayed to our user. The cost of forking a repo to view it is quite minimal in my opinion.

If this is something that needs improvements, then it should be something done through GitHub so that anyone using GitHub can preview and then edit the file.