search

spring-io / initializr

A quickstart generator for Spring projects
https://start.spring.io
Apache License 2.0
3.43k stars 1.73k forks source link

Milestone repository is added unnecessarily when using a snapshot of a maintenance release #1521

Closed inanemed closed 5 months ago

inanemed commented 5 months ago

Closes #1519

pivotal-cla commented 5 months ago

@inanemed Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 5 months ago

@inanemed Thank you for signing the Contributor License Agreement!

mhalbritter commented 5 months ago

Hey, thanks for the PR, but I don't think this fixes the problem.

3.3.0-SNAPSHOT could still depend on a milestone dependency (which is in the milestone repository). This PR would break that.

What Andy meant in https://github.com/spring-io/initializr/issues/1519 is that maintenance releases (x.y.z-SNAPSHOT where z > 0) don't need the milestone repos.

inanemed commented 5 months ago

Hey,thanks for the clarification.I appreciate it!

mhalbritter commented 5 months ago

Thank you very much and congratulations on your first contribution :tada:!