search

spring-io / issue-bot

12 stars 17 forks source link

Support replacing waiting for feedback with feedback provided on Pull Requests #15

Closed rwinch closed 5 years ago

rwinch commented 5 years ago

Currently the issue bot ignores pull requests all together. It would be nice if the issue bot would replace waiting for feedback with feedback provided on pull requests. However, just as it works today the bot would not close a pull request if feedback is not provided.

cc @rstoyanchev @philwebb

wilkinsona commented 5 years ago

Rob and I already discussed this on Slack and I am in favour. I'd like to reach agreement across all the teams using the Bot (Boot, Framework, and Security) before making the change.

rstoyanchev commented 5 years ago

We discussed this in the Spring Framework team, and agree with the change.

philwebb commented 5 years ago

+1

wilkinsona commented 5 years ago

Pull requests should now have their labels updated when feedback is provided. Please let me know if you see any unexpected behaviour.