Expose source as ConfigurableFileTree instead of FileTree

spring-io / nohttp

A project for ensuring that https is used

https://spring.io/blog/2019/06/10/announcing-nohttp

Apache License 2.0

225 stars 41 forks source link

Expose source as ConfigurableFileTree instead of FileTree #21

Closed sdeleuze closed 5 years ago

sdeleuze commented 5 years ago

Gradle Kotlin DSL is more statically typed, when using it it seems it is not possible to update the source property of NoHttpExtension without an explicit cast like (source as ConfigurableFileTree).exclude(). I think this property should be exposed with type ConfigurableFileTree (it seems to use this type internally) instead of FileTree to allow such common use case.

sbrannen commented 5 years ago

I can confirm that this is needed.

See https://github.com/junit-team/junit5/commit/228002cbb8ec31b43ef39823428ddad43d449824 for details.

rwinch commented 5 years ago

Thanks for the report @sdeleuze! Would you be interested in submitting a PR for this?