Use lombok to make the default visibility private

spring-io / pivotal-cla

Apache License 2.0

10 stars 16 forks source link

Use lombok to make the default visibility private #104

Closed Shredder121 closed 8 years ago

Shredder121 commented 8 years ago

This makes the default visibility a little more sane/secure.

rwinch commented 8 years ago

Thanks for the PR! I merged this in via 8384fc7e23bd1262c0ea3a36eab6e4a88d28a455

For some reason your changes didn't compile for me so I needed to make a small change I'm wondering if this was an Eclipse specific issue.

I also added a test for my own sanity.

Shredder121 commented 8 years ago

Huh. strange. It compiled for me though. I know that Javac has that issue on the top type level (you wouldn't be able to use a private 'member'.in an annotation value). I didn't know that Eclipse has that issue as well on member classes. Today I learned. Nice though!