search

spring-io / pivotal-cla

Apache License 2.0
10 stars 16 forks source link

Do not compare Boxed values with identity comparison #105

Closed Shredder121 closed 8 years ago

rwinch commented 8 years ago

Thanks for the report! You are right this was an issue. I changed the fix a little bit because I was not keen on adding apache commons as a direct dependency for something so simple. I also added some tests. See https://github.com/pivotalsoftware/pivotal-cla/commit/2ff81d4566eb98aed6064c0dea638dc60dfba9ff for details

Shredder121 commented 8 years ago

That's fine, I at least wanted a clean patch. :+1:

rwinch commented 8 years ago

Just wanted to let you know that I modified things (doesn't hurt to get a second set of eyes on it) :)

Shredder121 commented 8 years ago

That's true, looks good though!