search

spring-io / pivotal-cla

Apache License 2.0
10 stars 16 forks source link

The Manual Sync URL should not use CLA from the URL #110

Closed rwinch closed 8 years ago

rwinch commented 8 years ago

Currently the Manual Sync URL is:

https://cla.pivotal.io/sync/spring?repositoryId=spring-projects/spring-security@pullRequestId=123

We should not use the CLA name from the URL. Instead, we should look up the CLA in the github hooks of the Pull Request Hooks of the repository that is referenced. Alternatively, we could validate that the CLA name in the URL matches the CLA in the pull request hooks for the repository.

Shredder121 commented 8 years ago

Validating sounds best in my opinion. Just as an added measure.