search

spring-io / pivotal-cla

Apache License 2.0
10 stars 16 forks source link

Fix proofreading warnings #133

Closed Shredder121 closed 8 years ago

Shredder121 commented 8 years ago

I think the title says enough. There were some issues/typos in the CCLA text.

rwinch commented 8 years ago

@Shredder121 Thanks for the PR!

Unfortuantely we cannot merge this as is because it will break in production. This will happen because this schema was already merged and there is a table that validates the checksum. We need a new SQL file that will update the table to the new values. Any chance you could provide this?

Shredder121 commented 8 years ago

AH! Yes that makes sense. What naming should I use? Is it still V1, or V2?

rwinch commented 8 years ago

Thanks for the fast reply. Let's go with V1_3__fix-typos.sql

Shredder121 commented 8 years ago

I added a new file with the contents of the previous file with the typos fixed. You can verify using this command:

$ git show 6cb0b03c29efe0070d88e914aeba500318967612--find-copies-harder

Or optionally, to minimize the diff:

$ git show 6cb0b03c29efe0070d88e914aeba500318967612--find-copies-harder --color-words

EDIT: new sha hash for the commit.

Shredder121 commented 8 years ago

I would appreciate it if you could comment on my syntax. I wasn't quite sure about that name parameter. Usually that's an SQL keyword, so if I have to quote anything in a specific way, then let me know. Locally it works for me, so I can't quite tell.

rwinch commented 8 years ago

@Shredder121 Thanks for the update! This is merged via 6cb0b03c29efe0070d88e914aeba500318967612

You can verify using this command

Thanks for the tip. I use Beyond Compare for stuff like this :)

Usually that's an SQL keyword, so if I have to quote anything in a specific way, then let me know. Locally it works for me, so I can't quite tell.

It works fine for me and tested fine in our staging environment. This is now pushed to master so it will build and deploy to prod shortly.

Thanks again!

Shredder121 commented 8 years ago

Thanks for the tip. I use Beyond Compare for stuff like this :)

No problem, I just wanted to give you a pointer on how to verify my copy-paste work. But another tool is fine as well.

It works fine for me and tested fine in our staging environment.

Yes, locally I saw the same, but I wasn't sure on whether it would deploy or not. Good to hear/see that it did!

Thank you as well, for your time!