search

spring-io / pivotal-cla

Apache License 2.0
10 stars 16 forks source link

Confirmation comment is not posted consistently #140

Open snicoll opened 8 years ago

snicoll commented 8 years ago

Consider this issue: https://github.com/spring-projects/spring-framework/pull/1132

The initial request to sign the CLA was posted 5 days ago and the change was trivial so I was about to remind the reporter to sign the CLA and then I noticed that the status was green for this PR (including the fact that the CLA was indeed signed). So I thought the confirmation message wasn't posted (this isn't the first time this happens to me). I assigned myself and at the second I did that, the second comment was posted.

I've add this several times before in the last few days.

Shredder121 commented 8 years ago

I think the issue is that we don't wait enough after the issue is made. Sometimes, well-designed software (read: performant/fast) outspeeds GitHub, so it says that there is a new issue(via webhook), but then it returns 404s on you when you rush to the API. It might be a little overkill to wait this much, but it's not uncommon to have a slight delay in the processing.

I had already contacted GitHub a while back, but they can't easily reproduce the issue it seems.

Maybe someone with access to the logs of pivotal-cla can verify an exception was thrown at the time of the issue creation?

Shredder121 commented 8 years ago

_EDIT: I see this wasn't about the issue creation itself :sweatsmile:

Hmm. (It's however still a good idea to check whether we wait for a small delay or not, to not have that issue somewhere in the future)

mp911de commented 8 years ago

@snicoll Please ping us, if you find another issue like this one (has a green status, a comment that requires signing the CLA but no confirmation comment)

Regarding the PRs that are not updated once the CLA was signed (CLA signed, status red, no confirmation comment): How often does this happen?

snicoll commented 8 years ago

I've found a handful of them before reporting the issue. So it's definitely not the first time I see this.

ascherbaum-pivotal commented 7 years ago

Have another such a case right now:

https://github.com/greenplum-db/gpdb/pull/1206

Created this PR with my other development account, which has signed the CLA (and was used long before the new bot came into play). Right now the bot is not confirming my CLA.

rwinch commented 7 years ago

@ascherbaum-pivotal Thanks for reaching out. I don't think this is related. I looked through the dreadbot migration data provided to us by the Green Plum team and it does not contain a record for the GitHub account andreasscherbaum. I created https://github.com/pivotalsoftware/pivotal-cla/issues/146 for us to get this sorted out.