search

spring-io / pivotal-cla

Apache License 2.0
10 stars 16 forks source link

blue/green deploy means that GitHub OAuth key/secret invalid #92

Open rwinch opened 8 years ago

rwinch commented 8 years ago

GitHub requires we map the key/secret to single URL. This means the specific urls (i.e. pivotal-cla-production-blue.cfapps.io) will not be able to authenticate.

Ideally we would support this use case.

mp911de commented 8 years ago

We'll have to create Github applications for dev and staging. Going to ignore the issue we can't login to blue/green domains. Login is only possible using the external URL.

mp911de commented 8 years ago

@rwinch Could you create a staging application? I'd then adjust the deployment script to accept -Pproduction.oauth.clientId= and -Pstaging.oauth.clientId= so login is possible on staging and production environments.

rwinch commented 8 years ago

@mp911de We already have a staging app, but it is probably better called smoke test application. We deploy a new instance and wipe the database to run full integration tests against it. See https://github.com/pivotalsoftware/pivotal-cla/blob/b91221105fd0a464ad471561aadb5dda14527eb6/staging.gradle Perhaps we should change the name

Ultimately, I don't think we should spend time on this until we have a problem. We can always manually change the keys if we have an immediate need.

mp911de commented 8 years ago

Ok, then let's close this ticket and revisit it later once we run into trouble.

rwinch commented 8 years ago

I'm going to reopen since we know it is an issue. To me this is like an issue that a user reports that may impact one user, but not all users. This issue just doesn't impact us, so we won't prioritize time to it.