spring-io / spring-asciidoctor-backends

A backend for Asciidoctor used to produce Spring styled HTML
Apache License 2.0
77 stars 15 forks source link

Give priority to theme stored in localstorage #23

Closed koyama-tagbangers closed 3 years ago

koyama-tagbangers commented 3 years ago

This PR fix an issue applying dark mode forcely when prefers-color-scheme value is dark even though theme value is stored in localstorage.

I change to use prefers-color-scheme value only if theme value is not stored in localstorage or is an invalid value.

pivotal-cla commented 3 years ago

@koyama-tagbangers Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 3 years ago

@koyama-tagbangers Thank you for signing the Contributor License Agreement!

philwebb commented 3 years ago

Thanks for the fix and for signing the CLA. This has now been merged