search

spring-io / start.spring.io

https://start.spring.io
Apache License 2.0
2.24k stars 906 forks source link

Unneccessary Modulith dependencies defined when using database access starters #1400

Open Arondc opened 9 months ago

Arondc commented 9 months ago

If a project uses a database related starter (e.g. spring-boot-starter-data-jpa, spring-boot-starter-data-jdbc, ...) and also modulith is configured during project setup there are two modulith dependencies in the resulting pom/gradle file.

  1. spring-modulith-starter-core
  2. spring-modulith-starter-jpa / spring-modulith-starter-jdbc /...

The 2nd one always seems to contain the 1st one as a transient dependency, so it could be ommited during project setup.

This has no bigger impact on the project setup (nothing breaks as far as I see it) it just feels a bit strange.

odrotbohm commented 9 months ago

I'll have a look.

mhalbritter commented 7 months ago

Any news on this, @odrotbohm ? Should I take a look?