search

spring-petclinic / spring-petclinic-angular

Angular 16 version of the Spring Petclinic sample application (frontend)
205 stars 499 forks source link

Updates for the navbar, footer and welcome page #123

Closed dariusdv closed 1 year ago

dariusdv commented 1 year ago

Implementation for the navbar, footer and "welcome" component updates from issue https://github.com/spring-petclinic/spring-petclinic-angular/issues/121.

arey commented 1 year ago

@dariusdv did you have any screenshot? By the way, I dont know why the 16.x build has failed. I have to investigate

dariusdv commented 1 year ago

Hi @arey, Yes, the Home page will be like in this screenshot after the updates

image

dariusdv commented 1 year ago

@arey it seems that the build is failing due to conflicting peer dependencies. I think it either needs an update for @angular/cdk, or maybe the build commands can use the --force or --legacy-peer-deps flags. Maybe we can use the --force flag for this pull request and then I will upgrade the Angular version to 16, from this issue https://github.com/spring-petclinic/spring-petclinic-angular/issues/73?

While resolving: @angular/material@11.2.11
npm ERR! Found: @angular/cdk@11.2.10
arey commented 1 year ago

Could you try to upgrade the @angular/cdk in your PR please? Once merged, you could work on the Angular 16 upgrade. It would be much appreciated 👍

arey commented 1 year ago

It's working. Great!