search

spring-petclinic / spring-petclinic-graphql

PetClinic Example based on GraphQL
Other
212 stars 123 forks source link

spring-graphql example #36

Closed nilshartmann closed 2 years ago

nilshartmann commented 3 years ago

Hi,

on the branch spring-graphql I started implementing an example based on the recently announced new spring-graphql project.

I wonder if we:

  1. should replace the existing example (that uses the outdated graphql-java-tools lib, that is now graphql-java-kickstart with the spring-graphql-based one (merge spring-graphql-branch to master)
  2. or if we should create a new GitHub repo with the new example spring-graphql-example.

Myself, I'm unsure, but tend to option 1, as the current example is outdated anyway (and we can create an own branch for that example to make it still accessible for everyone) and spring-graphql might become the "offcial" GraphQL solution for spring anyway in the near future.

What do you think?

Best, Nils

arey commented 3 years ago

Hi Nils,

I saw this announcement and like you I believe that the new spring-graphql project will become the solution to adopt for GraphQL endpoint in the Spring ecosystem. Thus yes I may replace the master branch with your recent work.

Antoine

nilshartmann commented 3 years ago

Hi Antoine,

thanks for your feedback!

Before merging I'd like to add some tests, to make the example more feature complete.

Nils