Add new fields for retrieving owners by lastName.

spring-petclinic / spring-petclinic-graphql

PetClinic Example based on GraphQL

Other

212 stars 123 forks source link

Closed champagne closed 6 years ago

champagne commented 6 years ago

Add a new method for retrieving owners by the lastName. Got test result as following.

nilshartmann commented 6 years ago

Hi,

thank you very much for your pull request.

Would you mind making the field a little more "general"?

like "ownersByCriteria(criteria: { lastName: "..." })

I think that would be more "GraphQL-ish", as it allows more flexibility for clients.

champagne commented 6 years ago

Sure, will do it soon.

champagne commented 6 years ago

Hi Nils,

For your comment, one question, should we consider the and/or logic between multiple fields in the criteria?

BR, Sam

nilshartmann commented 6 years ago

Hi Sam,

I think 'and' semantic would be the way to go.

What do you think?

champagne commented 6 years ago

Hi Nils,

Please have a look at my code branch.

BR, Sam

nilshartmann commented 6 years ago

Hi Sam,

thank you very much for your contribution!

champagne commented 6 years ago

Hi Nils,

I'm so glad could be a contributor of spring-petclinic-graphql. I will try to do more later.

BR, Sam.