search

spring-petclinic / spring-petclinic-microservices

Distributed version of Spring Petclinic built with Spring Cloud
Apache License 2.0
1.7k stars 2.18k forks source link

Add user friendly error when Java < 17 is used #280

Closed arey closed 1 week ago

arey commented 1 month ago

See https://github.com/spring-projects/spring-petclinic/commit/7b1abb3ca9a0a47afbcf4299638fc09e37b2405a

AnkushThakur27 commented 1 week ago

@arey can i pickup this ? and one more questions do i need to add for all microservices ?

arey commented 1 week ago

Sure it is a good first issue

AnkushThakur27 commented 1 week ago

@arey WIP

AnkushThakur27 commented 1 week ago

@arey Sorry to bother you but I am not able to push my code chages due to permission issue. Can you add me as contributer ?

My User name : AnkushThakur27 email : aankushthakur27@gmail.com

20:44:16.918: [spring-petclinic-microservices] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain origin refs/heads/feature/#280:refs/heads/feature/#280 --set-upstream remote: Permission to spring-petclinic/spring-petclinic-microservices.git denied to AnkushThakur27.

AnkushThakur27 commented 1 week ago

Hi @arey Please review my pr : https://github.com/spring-petclinic/spring-petclinic-microservices/pull/286

arey commented 1 week ago

Close thanks to @AnkushThakur27