search

spring-petclinic / spring-petclinic-microservices

Distributed version of Spring Petclinic built with Spring Cloud
Apache License 2.0
1.69k stars 2.18k forks source link

Missing lombok compiler in pom.xml build section #285

Open hum2u opened 3 days ago

hum2u commented 3 days ago

compilation of submodules with lombok based getter/setter/no arg constructor annotations failed./setter method compilation failures on eclipse 2024-09

the issue was fixed when the following was added to the pm.xml files of such modules

`

org.apache.maven.plugins maven-compiler-plugin org.projectlombok lombok 1.18.34 
</build>`
AnkushThakur27 commented 2 days ago

@hum2u Can you tell me on which submodules you are getting this error ? I will start working on it asap.

hum2u commented 1 day ago

Anything with @Table annotation in source code, specifically Api-gatewayCustomers-serviceVets-serviceVisits- service

Sent from Yahoo Mail for iPad

On Wednesday, November 13, 2024, 1:48 PM, Ankush Thakur @.***> wrote:

@hum2u Can you tell me on which submodules you are getting this error ? I will start working on it asap.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

arey commented 1 day ago

Hi @hum2u did you setup Lombok into Eclipse as explained in this article: https://www.baeldung.com/lombok-ide ?

For information, we have an issue to get ride of Lombok: https://github.com/spring-petclinic/spring-petclinic-microservices/issues/251

hum2u commented 1 day ago

No. I was not aware of this mechanism. I naively assumed that the Pom files were all that were needed, and when the code did not compile because of missing generated Lombok getter/setter methods, I stumbled on the fix I mentioned by looking at other github projects that leveraged Lombok. Speaking for myself, I would prefer to have to do as little ide configuration as possible and have the Pom files take care of the build the app. I looked at the READMe file, I saw no clues or mentions of the needed ide configuration for the the article you referenced. Issue is that if your build solution should be independent of build environment. For example I don’t know how you would configure for Lombok in another build environment like Jenkins. Thanks

Sent from Yahoo Mail for iPhone

On Wednesday, November 13, 2024, 11:14 PM, Antoine Rey @.***> wrote:

Hi @hum2u did you setup Lombok into Eclipse as explained in this article: https://www.baeldung.com/lombok-ide ?

For information, we have an issue to get ride of Lombok: #251

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>