spring-projects-experimental / spring-boot-migrator

Spring Boot Migrator (SBM) is a tool for automated code migrations to upgrade or migrate to Spring Boot
Apache License 2.0
451 stars 89 forks source link

404 being presented as 401 #1031

Open dipaksand opened 10 months ago

dipaksand commented 10 months ago

Describe the bug During download attempt if an artefact is not found it is getting reported as unauthorised error

SBM Version Main branch latest - c96893fc770fb01d695f67a221235d0a866e72d1

SBM Application Shell

To Reproduce Steps to reproduce the behavior: Add a repository that does not contain a needed Pom and see the result after running the application

Expected behavior Not found should present as not found

Screenshots If applicable, add screenshots to help explain your problem.

Stacktrace If applicable, add the (sanitized) stacktrace here.

Example Source code to replicate the issue (Optional) It would help us immensely if we were to have an example test source code or a snippet where you can see this problem, you could attach a zip file along with this

MavenPomDownloader tried to reattempt download if there is a 404 and this time it does that without authentication. We probably can solve this by not attempting download if it is a 404 or attempt without credential only for a 401

P.S. Please remove any sensitive data and do not upload any proprietary source.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.