spring-projects-experimental / spring-boot-migrator

Spring Boot Migrator (SBM) is a tool for automated code migrations to upgrade or migrate to Spring Boot
Apache License 2.0
440 stars 88 forks source link

Exception: No version provided for dependency org.ehcache:ehcache #736

Closed karl-roth closed 11 months ago

karl-roth commented 1 year ago

Describe the bug Clicking on "Run Recipe" at http://localhost:8080/spring-boot-upgrade - 2.2.3. Remediation throws Exception: 'Bump Spring Boot to 3.0.0' failed: java.lang.RuntimeException: org.openrewrite.UncaughtVisitorException: org.openrewrite.maven.internal.MavenParsingException: No version provided for dependency org.ehcache:ehcache]

The version is inherited but nevertheless when i explicately add a version like this:

org.ehcache ehcache jakarta 3.10.8

the exception is still thrown.

SBM Version v0.13.0

SBM Application spring-boot-upgrade.jar

To Reproduce

  1. Add dependency above to your pom
  2. run java -jar --add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED spring-boot-upgrade.jar

Expected behavior That its just working or maybe give me a hint on how to solve that :)

Screenshots If applicable, add screenshots to help explain your problem.

Stacktrace org.openrewrite.maven.internal.MavenParsingException: No version provided for dependency org.ehcache:ehcache] with root cause org.openrewrite.maven.internal.MavenParsingException: No version provided for dependency org.ehcache:ehcache at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:525) at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:499) at org.openrewrite.maven.tree.MavenResolutionResult.resolveDependencies(MavenResolutionResult.java:159) at org.openrewrite.maven.UpdateMavenModel.updateResult(UpdateMavenModel.java:137) at org.openrewrite.maven.UpdateMavenModel.lambda$visitDocument$3(UpdateMavenModel.java:107) at org.openrewrite.marker.Markers.lambda$computeByType$0(Markers.java:97) at org.openrewrite.internal.ListUtils.lambda$map$0(ListUtils.java:141) at org.openrewrite.internal.ListUtils.map(ListUtils.java:123) at org.openrewrite.internal.ListUtils.map(ListUtils.java:141) at org.openrewrite.marker.Markers.computeByType(Markers.java:92) at org.openrewrite.maven.UpdateMavenModel.visitDocument(UpdateMavenModel.java:40) at org.openrewrite.xml.tree.Xml$Document.acceptXml(Xml.java:173) at org.openrewrite.xml.tree.Xml.accept(Xml.java:55) at org.openrewrite.TreeVisitor.visit(TreeVisitor.java:206) at org.openrewrite.TreeVisitor.visit(TreeVisitor.java:240) at org.openrewrite.RecipeScheduler.lambda$scheduleVisit$5(RecipeScheduler.java:241) at org.openrewrite.RecipeScheduler.lambda$mapAsync$0(RecipeScheduler.java:49) at org.openrewrite.scheduling.ForkJoinScheduler.lambda$schedule$0(ForkJoinScheduler.java:41) at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1375) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

Desktop (please complete the following information):

fabapp2 commented 11 months ago

Hi @karl-roth Please excuse my very delayed response. I assume the problem sits in the used OR recipe. I'll close this issue as the version became outdated, hoping it works in the revamped version, see #859