search

spring-projects-experimental / spring-boot-migrator

Spring Boot Migrator (SBM) is a tool for automated code migrations to upgrade or migrate to Spring Boot
Apache License 2.0
441 stars 88 forks source link

Windows path fixes #965

Closed ammachado closed 11 months ago

ammachado commented 12 months ago

Fixes #958

fabapp2 commented 12 months ago

HI @ammachado Thanks for picking this 🚀 I started on fix/958-fix-build-with-windows but my Windows "machine" makes progressing hard (it's very slow) and I missed opening a draft PR. Just realized the base branch for your PR is the 985 branch. 😬

fabapp2 commented 12 months ago

Something was broken, when running mvn clean install, in spring-shell I get

[ERROR] Errors: 
[ERROR]   BootUpgrade_27_30_IntegrationTest.migrateSimpleApplication:45->IntegrationTestBaseClass.scanProject:211 » IllegalArgument Can't read recipes from resource 'spring-context-xml-import.yaml'
[ERROR]   BootUpgrade_27_30_MultiModule_IntegrationTest.migrateMultiModuleApplication:43->IntegrationTestBaseClass.scanProject:211 » IllegalArgument Can't read recipes from resource 'spring-context-xml-import.yaml'
[ERROR]   MigrateJpaApplicationIntegrationTest.migrateJpaApplication:35->IntegrationTestBaseClass.scanProject:211 » IllegalArgument Can't read recipes from resource 'spring-context-xml-import.yaml'
[ERROR]   MigrateJaxRsAnnotationsRecipeIntegrationTest.happyPath:136->IntegrationTestBaseClass.scanProject:211 » IllegalArgument Can't read recipes from resource 'spring-context-xml-import.yaml'
[ERROR]   MigrateJsf2xToSpringBootRecipeIntegrationTest.testRecipe:57->IntegrationTestBaseClass.scanProject:211 » IllegalArgument Can't read recipes from resource 'spring-context-xml-import.yaml'
[ERROR]   MigrateXmlBeanConfigurationToJavaConfigIntegrationTest.testRecipe:76->IntegrationTestBaseClass.scanProject:211 » IllegalArgument Can't read recipes from resource 'spring-context-xml-import.yaml'
[INFO] 
[ERROR] Tests run: 13, Failures: 0, Errors: 6, Skipped: 7
[INFO]

These tests require a Docker container and thus don't run (yet) in GH actions.

fabapp2 commented 12 months ago

@ammachado are you running under Windows? I have a hard time testing the build with the Windows machine I have at hand.

fabapp2 commented 11 months ago

HI @ammachado thanks for your adjustments! I only had a glimpse but didn't immediately see how the last commit relates to the Windows paths problem? If it isn't, please create a new issue describing the requirements for the last commit, prepare a separate PR, and move this commit there. I will not be available next week and would like to merge your changes and mine into main asap as these will then hopefully make main run under Windows again. Anything related can go into this PR. Also, I had a few comments about the calls in some test, could you remove these calls as they're redundant? Thank you!

ammachado commented 11 months ago

HI @ammachado thanks for your adjustments! I only had a glimpse but didn't immediately see how the last commit relates to the Windows paths problem? If it isn't, please create a new issue describing the requirements for the last commit, prepare a separate PR, and move this commit there. I will not be available next week and would like to merge your changes and mine into main asap as these will then hopefully make main run under Windows again. Anything related can go into this PR. Also, I had a few comments about the calls in some test, could you remove these calls as they're redundant? Thank you!

I removed the calls and moved the extra commit to a separate branch. I'm also away from my Windows machine until the second week of November.