search

spring-projects-experimental / spring-boot-thin-launcher

Tools for building "thin" executable jars, with a focus on, but not exclusively for, Spring Boot
https://github.com/dsyer/spring-boot-thin-launcher
Apache License 2.0
681 stars 90 forks source link

why is that thin root is not preferred while preparing the local repo on mavenRepositories method #130

Closed AminLA closed 4 years ago

AminLA commented 4 years ago

at org.springframework.boot.loader.thin.DependencyResolver

private List<ArtifactRepository> mavenRepositories(MavenSettings settings, RepositorySystemSession session,
        Properties properties) {
    ...
    if (properties.containsKey(ThinJarLauncher.THIN_ROOT)) {
        addRepositoryIfMissing(settings, session, list, "local",
            "file://" + localRepositoryPath(new Properties(), settings, false), true, false);
    }
    ...

should it be 

private List<ArtifactRepository> mavenRepositories(MavenSettings settings, RepositorySystemSession session,
        Properties properties) {
    ...
    if (properties.containsKey(ThinJarLauncher.THIN_ROOT)) {
        addRepositoryIfMissing(settings, session, list, "local",
            "file://" + localRepositoryPath(properties, settings, true), true, false);
    }
   ...