spring-projects-experimental / spring-boot-thin-launcher

Tools for building "thin" executable jars, with a focus on, but not exclusively for, Spring Boot
https://github.com/dsyer/spring-boot-thin-launcher
Apache License 2.0
681 stars 90 forks source link

Location of settings.xml is inconsistent with docs #208

Closed dsyer closed 9 months ago

dsyer commented 9 months ago

In the README it suggests that you can use maven.repo.local to locate the settings.xml but that doesn't work and isn't tested. The MavenSettingsReader is initialized with the thin.root as a "home" directory (if set) and that is wrong really - it should be a couple of levels above that logically by analogy with ~/.m2. That's 2 problems, but I'll lump them together and try and fix them both at the same time.