add JaFu Redis DSL - Githubissues

spring-projects-experimental / spring-fu

Configuration DSLs for Spring Boot

Apache License 2.0

1.67k stars 138 forks source link

add JaFu Redis DSL #283

Closed agebhar1 closed 3 years ago

agebhar1 commented 4 years ago

This is WIP for #278 if it's the right direction I'll add (integration) tests.

Cassandra DSL
Redis DSL

I'm looking forward for feedback.

sdeleuze commented 4 years ago

Hi, thanks for your contribution, yes I think this is going in the good direction so please provide integration tests and I will review it more in depth before merging it.

agebhar1 commented 4 years ago

Thanks for your reply. I will continue to implement the integration tests.

agebhar1 commented 4 years ago

This PR is now reduced to the JaFu Redis DSL. The Cassandra DSL is requested by #286.

I added (basic) integration tests and I'm looking forward for your feedback.

agebhar1 commented 4 years ago

@sdeleuze this PR is ready for review. Should there be detailed tests for each configuration (combination)?

After the review all commits could be squashed.

sdeleuze commented 4 years ago

We will review this PR shortly sorry for the delay.

sdeleuze commented 3 years ago

Merged thanks for your patience.