search

spring-projects-experimental / spring-fu

Configuration DSLs for Spring Boot
Apache License 2.0
1.67k stars 138 forks source link

feat #274 Add new generic R2dbcDsl with native support from Spring Boot #289

Closed aneveu closed 4 years ago

aneveu commented 4 years ago

Fixes: #274

Create a new DSL for R2dbc using R2dbcProperties from Spring Boot 2.4 and a new generic initializer.

Could you please confirm if all values could stay nullable or if some default values should be used (and if so, which one? Embedded H2? Other?)

Also, we tried to create new tests for R2dbc but we are stuck by the fact that DatabaseClient is not part of dependencies of the project. What's the test guideline? Should the dependency be added or do we consider that sample projects working is enough testing?

And finally, should we delete the previous implementations for H2 and Postgres or should we keep them?

aneveu commented 4 years ago

ping @fteychene

sdeleuze commented 4 years ago

Thanks for this contribution.

Could you please confirm if all values could stay nullable or if some default values should be used (and if so, which one? Embedded H2? Other?)

I think it is fine to keep Spring Boot defaults yeah.

Also, we tried to create new tests for R2dbc but we are stuck by the fact that DatabaseClient is not part of dependencies of the project. What's the test guideline? Should the dependency be added or do we consider that sample projects working is enough testing?

In Spring Framework 5.3, the R2DBC client is now directly integrated via the spring-r2dbc, it would be nice to leverage it as part of the tests in addition to the sample project if possible.

And finally, should we delete the previous implementations for H2 and Postgres or should we keep them?

I think we can remove them, but I am wondering how the database to use is now configured, is it via parsing the url property + via classpath conditions? Would be nice to test.

Could it be possible to update the JaFu side as well?

sdeleuze commented 4 years ago

Merged, thanks for this great contribution :+1: