spring-projects / eclipse-integration-tcserver

Eclipse Integration for vFabric tc Server
Eclipse Public License 1.0
15 stars 22 forks source link

updating labels, server fixtures and tests for tc Server v2.8 #1

Closed zaza closed 11 years ago

zaza commented 11 years ago

I noticed that in /com.vmware.vfabric.ide.eclipse.tcserver.core/plugin.xml there is a number of extensions for com.springsource.sts.ide.configurator.serverConfigurations extension point. It looks that I should add a new one for the new server, but frankly speaking couldn't figure out what the extension actually does. I even removed all of them and still was able to create a new server and start it afterwards.

The only consumer of those extension is org.springsource.ide.eclipse.commons.internal.configurator.server.ServerConfigurator. Its only purpose seems to be tested by org.springsource.ide.eclipse.commons.internal.configurator.server.ServerConfiguratorTest. Do I miss something?

leods commented 11 years ago

Looks good so far, but yes we do want another entry for the serverConfigurations extension point. ServerConfigurator will also be called by org.springsource.ide.eclipse.commons.internal.configurator.server.ServerWorkspaceConfigurator which is a WorkspaceConfiguratorParticipant. Other examples of WorkspaceConfiguratorParticipants include MavenRuntimeWorkspaceConfigurator and RooInstallWorkspaceConfigurator to name a couple.

What these do is, when a new workspace is launched for the first time, these will attempt to configure the workspace with appropriate server, Maven, Roo, Grails...etc. runtimes and settings. You can observer this if you download the STS RCP, it's bundled alongside directories with Maven, Roo, and tc Server. Launching the RCP will search these directories, find the runtimes and set them up for STS with the user not needing to make any configurations!

zaza commented 11 years ago

Thanks for clearing that up Leo, got it now! I looked for refs of ServerConfigurator's constructor (not the class itself) in my workspace, and this is why I missed the ServerWorkspaceConfigurator. The new commit contains the new extension for serverConfigurations.

leods commented 11 years ago

Perfect. Thanks Tomasz.