search

spring-projects / eclipse-integration-tcserver

Eclipse Integration for vFabric tc Server
Eclipse Public License 1.0
15 stars 22 forks source link

[tc server] selecting "serve modules without publishing" option is failing with exception. #8

Closed lak-proddev closed 6 years ago

lak-proddev commented 6 years ago

selecting serve modules without publishing option is failing with exception. See below SS

Loader jar not found for server ID: org.eclipse.jst.server.tomcat.runtime.90.

image

BoykoAlex commented 6 years ago

should be fixed now

lak-proddev commented 6 years ago

Thanks for the fix. But, the commit only fixes the exception. Actual option doesn't work properly.

I think, this issue will be fixed by overriding this method in tc server code. org.eclipse.jst.server.tomcat.core.internal.TomcatServerBehaviour.publishFinish(IProgressMonitor)

We need to map tc server id to tomcat runtime Id.

See this line

TomcatServerBehaviour.java line 352

String tomcatVersion = TomcatVersionHelper.getCatalinaVersion(getServer().getRuntime().getLocation(), serverTypeID);

com.vmware.vfabric.ide.eclipse.tcserver.internal.core.TcServerVersionHandler.mapToTomcatRuntimeId(IPath, String)

BoykoAlex commented 6 years ago

Hopefully fixed now. Since you're diving into the source code feel free to create PRs for stuff you find not working. We'll gladly merge them :-)

FYI: I see that deploying to tc server 3.x with tomcat 7.0.x isn't working but everything else seems to be in order. Looking into it now.

BoykoAlex commented 6 years ago

NVM, it deploys fine, just need to create proper boot app

lak-proddev commented 6 years ago

Still, I couldn't deploy application. I think, this would be the fix.

Issue-8tc-server-selecting-serve-modules-without-pub.txt

martinlippert commented 6 years ago

Would you be interested in submitting this as a pull request? In case so, please make sure to read the guidelines for contributing code and sign the contributors license agreement: https://github.com/spring-projects/eclipse-integration-tcserver/blob/master/CONTRIBUTING.adoc

That would be fantastic!!!