spring-projects / spring-ai

An Application Framework for AI Engineering
https://docs.spring.io/spring-ai/reference/index.html
Apache License 2.0
3.33k stars 858 forks source link

Modular RAG - Query Analysis #1703

Closed ThomasVitale closed 1 week ago

ThomasVitale commented 2 weeks ago

Query Analysis

Improvements

Tests

Relates to #gh-1603

markpollack commented 1 week ago

Just some general thoughts, not necessary to resolve for this PR.

this way additional information that can be used by an implementing class can be taken into account. The document is the core part, but there could be additional information to influence how the query gets augmented. Perhaps that would be passed in the constrcutor to the QueryAugmentor impl. Just looking to move away from types that don't have extensibility in the interface.

markpollack commented 1 week ago

I get test failures for tests org.springframework.ai.integration.tests due to the api-key not being set. Prob works in your environment but in my I don't have any spring.ai.openai.*properties set.

markpollack commented 1 week ago

merged in 263fe2fba7b6e940ac802e996db474d8909fe5d2