search

spring-projects / spring-ai

An Application Framework for AI Engineering
https://docs.spring.io/spring-ai/reference/index.html
Apache License 2.0
3.33k stars 858 forks source link

rename timeToLiveSeconds of cassandra property #1737

Closed jitokim closed 1 week ago

jitokim commented 1 week ago

fix issue #1728

rename timeToLiveSeconds to timeToLive because the type is Duration.

add test code for ISO-8601 Format and also numeric type

image image
jitokim commented 1 week ago

The reason I changed the name of timeToLiveSeconds without changing its type is,

Using the Duration type allows us to preserve the ISO-8601 format, but its default unit is milliseconds.

To keep the function name (withTimeToLive) and its parameter type (Duration) consistent in the CassandraChatMemoryConfig class.

markpollack commented 1 week ago

Thanks, merged in a7a1804fac2987dd2f34640733a29f94e1b46a9c