GH-1749 Fix Chroma query/delete operation

spring-projects / spring-ai

An Application Framework for AI Engineering

https://docs.spring.io/spring-ai/reference/index.html

Apache License 2.0

3.32k stars 850 forks source link

GH-1749 Fix Chroma query/delete operation #1779

Closed ilayaperumalg closed 1 day ago

ilayaperumalg commented 2 days ago

When Chroma query/delete operation doesn't involve a where clause, the latest Chroma API doesn't allow an empty map for the where parameter. This requires both the query and delete operations to remove explicit setting of where parameter with empty map.
- Check the filter clause to query with or without where parameter
- Update both query and delete operations
- Update tests
- Update the latest Chroma image 0.5.18 in the tests

Resolves #1749

tzolov commented 1 day ago

@ilayaperumalg I've refreshed and improved our ChromaAPI implementation. It should solve the handling to empty fields reusing the existing api without additional constructs. I've added simple-search IT to verify it.

https://github.com/spring-projects/spring-ai/pull/1780

ilayaperumalg commented 1 day ago

@tzolov sure, thanks for the update. Closing this PR for https://github.com/spring-projects/spring-ai/pull/1780