spring-projects / spring-amqp

Spring AMQP - support for Spring programming model with AMQP, especially but not limited to RabbitMQ
https://spring.io/projects/spring-amqp
Apache License 2.0
806 stars 619 forks source link

TraceId propagation to the new thread local #2608

Open TJackler opened 7 months ago

TJackler commented 7 months ago

The scenario and details are located here: https://github.com/micrometer-metrics/tracing/issues/510#issue-2066891159

Version: 3.1.1

artembilan commented 7 months ago

From that description it sounds like the use-case is pretty complex, so would be great to have some simple project from you to play with. Does it work well if you change that CompletableFuture<String> to just String?

TJackler commented 7 months ago

Yes, it works correctly without CompletableFuture.

artembilan commented 7 months ago

OK. So, then my request for a simple project is the next step what we can do over here.

artembilan commented 5 months ago

According to the code there is no observation on sending a reply from the Rabbit listener method, so I'm failing to understand how it may work without a CompletableFuture. Do you still think you would have a chance to share with us some project to let us reproduce? Thanks