search

spring-projects / spring-aot-smoke-tests

Smoke tests for Spring's AOT and native support
https://spring-team-aot-smoke-tests-dashboard.azuremicroservices.io/
51 stars 35 forks source link

Investigate using mccutchen/go-httpbin #184

Closed wilkinsona closed 1 year ago

wilkinsona commented 1 year ago

I think we should take another look at the changes made for https://github.com/spring-projects/spring-aot-smoke-tests/issues/180. It may be possible to revert much of them and use mccutchen/go-httpbin running in a container in place of http(s)://httpbin.org.

wilkinsona commented 1 year ago

https://hub.docker.com/r/kennethreitz/httpbin is another option. It's the "original" implementation and is what's running at https://httpbin.org.

mhalbritter commented 1 year ago

I found https://hub.docker.com/r/kennethreitz/httpbin while looking for a suitable docker replacement. The problem with it is that it doesn't support ARM machines. I'm in favor of the Go re-implementation.

wilkinsona commented 1 year ago

Thanks, Moritz. I hadn't released that httpbin was x64 only. Let's use go-httpbin then.

wilkinsona commented 1 year ago

I think this has broken the tests for HTTPS. For example rest-template started to fail with https://github.com/spring-projects/spring-aot-smoke-tests/commit/bc7195d00d00bbd76c6dd5f4e966f39b851f05c5. See https://ci.spring.io/teams/spring-aot-smoke-tests/pipelines/spring-aot-smoke-tests-3.0.x/jobs/rest-template-app-test/builds/81.

mhalbritter commented 1 year ago

Oh :( I'm going to take a look.

mhalbritter commented 1 year ago

We're using an old docker compose version which doesn't support the configs element in the compose file. #187 updates docker compose to a newer version.

mhalbritter commented 1 year ago

And i botched the regex. It worked on my machine because it was localhost, but on the CI it's an IP address and \w+ doesn't match IP addresses.

wilkinsona commented 1 year ago

Thanks, @mhalbritter.