search

spring-projects / spring-batch-extensions

Spring Batch Extensions
242 stars 258 forks source link

Blank row excel #24

Closed Krishna9331 closed 3 years ago

Krishna9331 commented 8 years ago

There is a issue with the existing code if we implement this in spring batch for below condition:

1)If Excel sheet has continuous blank row at last 2)If Excel Sheet has Blank row in the middle(sample.xml attached)

In such case The Reader phase of Spring batch unnecessary continue looping even there is no data in the excel sheet.

mdeinum commented 8 years ago

Thanks for the pull request (although I cannot merge it). Could you rebase this with the current master, as there seems to be more changes not related to the issue at hand in this pull request.

Krishna9331 commented 8 years ago

@mdeinum I have created separate pull request, since I saw there was few logic change in current master. https://github.com/spring-projects/spring-batch-extensions/pull/31

mdeinum commented 3 years ago

This was largely a part of #65.