search

spring-projects / spring-batch-extensions

Spring Batch Extensions
242 stars 258 forks source link

Move to next sheet when there are only empty/invalid rows #82

Closed cesaralves closed 2 years ago

cesaralves commented 2 years ago

When there are blank or empty lines in the end of one sheet, null is returned by doRead without trying to read next sheet. A recursive call makes sheet moving happen when another exists.

mdeinum commented 2 years ago

Thanks for the enhancement on the reader. Could you please also provide a test case for this scenario so that we know that this is covered. Ideally a test in the base test class so that it will be applied to xls, xlsx and the streaming part.

cesaralves commented 2 years ago

Added a test case for XLS files