search

spring-projects / spring-batch

Spring Batch is a framework for writing batch applications using Java and Spring
http://projects.spring.io/spring-batch/
Apache License 2.0
2.73k stars 2.35k forks source link

Batch table relationship description seems to be wrong. #4653

Open chaenabi opened 2 months ago

chaenabi commented 2 months ago

StackOverflow.

Hello, after writing the question above I couldn't pay attention for a while. if the above issue is still valid, please concern to correct the description picture.

The photo and file below are a list of attached files for requesting correction. (The zip file is a Mysql Workbench model diagram (mwb extension) file.)

batch_erd batch_erd.zip

fmbenhassine commented 2 months ago

Thank you for opening this issue. The SO thread refers to an outdated version of the documentation (v3).

The diagram was updated to v5 in #4358, so I think this issue can be closed. Let me know if you see another required update.

chaenabi commented 2 months ago

Thanks for the reponse. I wonder it looks like the updated picture still describes at #4358 BATCHSTEP_EXCEUTION_CONTEXT / BATCH_STEP_EXECUTION tables as many to one relationship (BATCH_JOB_EXECUTION / BATCH_JOB_EXECUTION_CONTEXT too) aren't each table a one-to-one relationship anymore?

fmbenhassine commented 2 months ago

I see. This is actually the output of MySQL workbench for the given schema, which seems to be inaccurate (I don't see how to alter that). However, the corresponding text describing the tables is accurate:

There is exactly one Job ExecutionContext for each JobExecution, [...]

Is that what you are looking for?

chaenabi commented 2 months ago

yes I am. if this is acceptable to you, you may see the picture #4653 to update

fmbenhassine commented 2 months ago

OK I see the difference with your update (relations are now one-to-one), thank you for doing that! 👍

I will re-open this issue and plan the fix for the next release.