search

spring-projects / spring-boot

Spring Boot
https://spring.io/projects/spring-boot
Apache License 2.0
74.76k stars 40.59k forks source link

Prune samples tests #12724

Open mbhave opened 6 years ago

mbhave commented 6 years ago

A few of the samples tests don't run on CI but still take up time. We can most likely delete them as there are other tests using TestContainers that cover that:

There are a few others that don't seem to test the sample they're part of. For example, SampleDevToolsApplicationIntegrationTests passes even if devtools is not on the classpath. Since we have other integration tests for DevTools, these can probably go. SampleAopApplicationTests also doesn't test the relevant aop parts.

wilkinsona commented 6 years ago

I think we should use this issue and #6370 to review all of our samples, decide what they should be used for, and update and name them accordingly.

scottfrederick commented 2 years ago

The data-related smoke tests that require a server will be removed in #30875. We will leave this issue open to do the suggested additional review.