search

spring-projects / spring-boot

Spring Boot helps you to create Spring-powered, production-grade applications and services with absolute minimum fuss.
https://spring.io/projects/spring-boot
Apache License 2.0
75.26k stars 40.7k forks source link

Add maven-scm-plugin + maven-release-plugin to spring-boot-dependencies #14201

Closed ST-DDT closed 6 years ago

ST-DDT commented 6 years ago

Please add the maven-scm-plugin + maven-release-plugin to the plugin-management-section, because the default versions that will be used by some maven versions contains a bug, that it does not create a git-commit before a release.

https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-scm-plugin https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-release-plugin https://stackoverflow.com/questions/15166781/mvn-releaseprepare-not-committing-changes-to-pom-xml https://issues.apache.org/jira/browse/MRELEASE-812

Side-note/Offtopic:

Also the it would be nice if you could include the maven-versions-plugin v2.6 update that is about to be released (Properly detect configured maven version requirements). https://github.com/mojohaus/versions-maven-plugin/issues/269#issuecomment-415849842

philwebb commented 6 years ago

Thanks for the suggestion but I think we're in danger of trying to manage too many dependencies if we take on additional Maven plugins that we don't use directly ourselves. For something like this, I think it's best if you create your own parent POM that inherits from ours and adds the extra plugins that you need.