search

spring-projects / spring-boot

Spring Boot helps you to create Spring-powered, production-grade applications and services with absolute minimum fuss.
https://spring.io/projects/spring-boot
Apache License 2.0
75.06k stars 40.66k forks source link

Spring-boot-actuator does not use validation query provided by DataSourceCreator object #1670

Closed gauthierj closed 10 years ago

gauthierj commented 10 years ago

Hi, I've create a Spring-cloud connector for DB2 (see this pull request : https://github.com/spring-cloud/spring-cloud-connectors/pull/87). But Spring-boot actuator does not use the validation query provided by the DataSourceCreator object.

Thanks, regards,

Gauthier

snicoll commented 10 years ago

That's actually not the only source we could use to get the validation query. We implemented recently #1282 which reuse the configuration of the datasource Boot builds. #1287 may provide better defaulting.

If that does not work, it means the DataSource that spring cloud provides does not have a proper DataSourceMetadata attached to it. Maybe we need an extra DataSourceMetadataProvider for this case. ping @dsyer

snicoll commented 10 years ago

As we discussed offline, you're using 1.1.6 and #1282 is implemented in 1.2. Could you please try with 1.2.0.M1 ?

gauthierj commented 10 years ago

Yes indeed, it works fine with 1.2.0.M1.

Thanks, regards,

Gauthier