search

spring-projects / spring-boot

Spring Boot
https://spring.io/projects/spring-boot
Apache License 2.0
73.6k stars 40.32k forks source link

Declaring a user-defined WebServerFactory should make sure the auto-configuration backs off #24706

Open snicoll opened 3 years ago

snicoll commented 3 years ago

See #24705

We initially designed things this way because we wanted an easy way for users to opt-in for the embedded server of their choices if they happen to have two on the classpath and the one the auto-configuration picked was not the one they wanted to use.

This corner case makes the auto-configuration at odds with others. If you register a WebServerFactory the customizers are applied anyway. This means also that whatever you configure in the factory itself is likely to be lost since default opinions are going to be applied after that.

Changing this behaviour is a breaking change that could surprise more than one user. We may want to keep the current behaviour , perhaps using a configuration property. This would help users to migrate.

wagnerluis1982 commented 2 years ago

Hi, is this open for contributors? If yes, I'd like to be assigned to it.

scottfrederick commented 2 years ago

@wagnerluis1982 Thanks for the offer. This issue is assigned to the 3.x milestone, and we will not be ready to accept contributions for that milestone until we've cut branches and gotten some infrastructure ready for it.

philwebb commented 2 years ago

We've decided that whilst we might want to tackle this at some point, we don't want to add complications for people upgrading from Boot 2.x to 3.0.x. Since we've not had that many complaints from the community, we think it might be better to take this on at a point release where it will be easier for users to spot.