search

spring-projects / spring-boot

Spring Boot helps you to create Spring-powered, production-grade applications and services with absolute minimum fuss.
https://spring.io/projects/spring-boot
Apache License 2.0
75.19k stars 40.69k forks source link

Resolve JDBC driver class name for AWS drivers #31995

Open maciejwalkowiak opened 2 years ago

maciejwalkowiak commented 2 years ago

Spring Boot could resolve JDBC driver class names for AWS variants of MySQL and PostgreSQL drivers:

If you believe this change makes sense, I would be happy to contribute a PR.

wilkinsona commented 2 years ago

Thanks for the suggestion, @maciejwalkowiak. This could be a nice addition, particularly for aws-mysql-jdbc. I think it may be better to wait for jdbc:postgresql:aws to stabilise before we add support for it. A PR that adds support for MySQL would be most welcome. Thanks.

maciejwalkowiak commented 2 years ago

I noticed few days ago there is a new JDBC driver related project from AWS in progress (https://github.com/awslabs/aws-advanced-jdbc-wrapper - 404 for now) - not sure if it only replaces Postgres driver or as the name suggests will cover more database types. Perhaps @susanmdouglas-aws or @marksailes can shine some light? So that we don't integrate driver that gets deprecated in upcoming months.

wilkinsona commented 2 years ago

I'd noticed that yesterday and got the same 404 but hadn't taken the time to investigate. Thanks for doing that, @maciejwalkowiak. I agree that we should hold off until the role of the new JDBC driver becomes clear.

susanmdouglas-aws commented 2 years ago

Hi - Can I recommend you reach out to @adalevinAWS for more information?

adalevinAWS commented 2 years ago

I'll update here once we have more information to share. I see you added the on-hold label for now, though. Thank you.

vpavic commented 1 year ago

Release 1.0.0 of software.amazon.jdbc:aws-advanced-jdbc-wrapper (hosted on https://github.com/awslabs/aws-advanced-jdbc-wrapper) has apparently been published in early October.

With that in mind, maybe this could be revisited?

wilkinsona commented 1 year ago

@adalevinAWS any updates on your side?

vpavic commented 1 year ago

Since the last update here, AWS Advanced JDBC Driver project published a few releases (including the recent v2.0.0) and has generally been adding features valuable for users of Aurora-flavored DBs from AWS.

So it seems there aren't any reasons to keep this on-hold.

wilkinsona commented 1 year ago

Given that the project seems to be quite well established, I guess we could assume that it's safe to proceed. I'd still welcome confirmation from @adalevinAWS though.

hsuamz commented 1 year ago

Thanks @wilkinsona.

I'm from the team with the AWS drivers. We are focusing our efforts right now on the aws-advanced-jdbc-wrapper, in particular on certifying it for Aurora MySQL. We would welcome the PR for the aws-advanced-jdbc-wrapper.

Thank you.

maciejwalkowiak commented 1 year ago

@hsuamz any ETA for Aurora MySQL support?

wilkinsona commented 1 year ago

Thanks, @hsuamz.

davecramer commented 1 year ago

@maciejwalkowiak There is (should be) no real difference between mysql and postgres as the driver "wraps" the underlying drivers. The existing driver is what will be released for mysql